feat: unlimited pending sign txs whitelist#31
Merged
Conversation
karim-en
requested changes
Apr 9, 2026
frolvanya
reviewed
Apr 9, 2026
frolvanya
reviewed
Apr 9, 2026
|
|
||
| pub fn internal_get_account(&self, account_id: &AccountId) -> Option<&Account> { | ||
| self.data().accounts.get(account_id).map(Into::into) | ||
| pub fn internal_get_account(&self, account_id: &AccountId) -> Option<Account> { |
Author
There was a problem hiding this comment.
I just decided to implement a lazy account migration. If we request mut, we upgrade the account to the new version. If it’s view, we convert it locally. Because of this approach, we can’t return a reference, since a conversion happens.
As an alternative, we could implement a separate migration function and migrate accounts in batches. But I kind of like the lazy approach more.
karim-en
requested changes
Apr 15, 2026
karim-en
reviewed
Apr 15, 2026
karim-en
requested changes
Apr 15, 2026
karim-en
approved these changes
Apr 15, 2026
frolvanya
approved these changes
Apr 17, 2026
kiseln
approved these changes
Apr 17, 2026
olga24912
added a commit
that referenced
this pull request
Apr 17, 2026
* option -> hashset * add whitelist for unlimited txs * add migration test * lazy migration for accoun * fix lint * add limit for unlimited txs * check whitelist everywhere * whitelist set -> map * remove new config * fmt * renaming * remove unwrap_account function * unite set and reset pendig tx list * get_account ref
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OmniBridge acts as the sender for all withdraw transactions. Previously, an account could only have one pending-sign transaction at a time — it had to wait for MPC signing to complete before creating another. This became a bottleneck for
OmniBridge, which needs to submit new withdrawals in parallel while existing ones are still being signed.